This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Handle the issue with FNB's multiple elements on a single line which …#35
Open
jacques wants to merge 11 commits intoasgrim:masterfrom
Open
Handle the issue with FNB's multiple elements on a single line which …#35jacques wants to merge 11 commits intoasgrim:masterfrom
jacques wants to merge 11 commits intoasgrim:masterfrom
Conversation
…throws 'RuntimeException: Failed to initialize DateTime for string:'
Owner
|
Hmm, not currently sure how to make this more clever regarding the various ways the OFXs are generated. Ideally, we need to conform to spec (we'd need to read up on it), and if an OFX doesn't follow spec, then it wouldn't be supported... |
asgrim
suggested changes
Jan 7, 2017
Owner
asgrim
left a comment
asgrim
left a comment
There was a problem hiding this comment.
Rejecting for now as it's breaking existing support for other line endings (that's a no-go unless targeting a BC break release)
Owner
|
@jacques what are the differences here in the 2.00 format please? Does it actually warrant a second class? Also missing tests for this new class :/ |
asgrim
added
BC break
…ide, reported issue asgrim#49
Some OFX files don't have all the date tags. So when the value of the date tag that doesn't exist and it is passed as a parameter to $dateString into the function "createDateTimeFromStr", this function returns "=> Failed to initialize DateTime for string: ". To bring more flexibility, I suggest testing first if dateString is set and is not empty before converting it into a string.
In OFX files, some tag values like in MEMO tag contains special characters such as the 'at' sign (@) which generate an issue with simplexml_load_string function. `LibXMLError::__set_state(array( 'level' => 3, 'code' => 68, 'column' => 30, 'message' => 'xmlParseEntityRef: no name ', 'file' => '', 'line' => 27, )),` This code simply converts the '&' sign to its html code (&) which is tolerated by simplexml_load_string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…throws 'RuntimeException: Failed to initialize DateTime for string:'