Open
Conversation
racing.proto: • Added optional string parameter `order_by` as per Google design spec[1]. races.go: • Changed `List` funct to accept ListRacesRequest param - this is required for accessing parameters outside of the filter. • Added function `applyOrdering` which appends ORDER BY statement. By default it orders by `advertised_start_time` but also allows for custom ordering. • Added function `toOrderBySql` which converts unvalidated external input for order by query and converts to a safe SQL format.
Correct out-of-date naming for RacesRepo interface List function.
• Update order by comment to describe usage.
• Added order by name test.
• Expanded order by test case to ensure that multi space, multi fied sorting is obeyed.
• Added line for order by parameter detailing its purpose.
• Fixed invalid testType of "db" for races_test.
• Fixed failing test cases due to compilation error with Init change. • Fixed database in use error due to test case access other test cases databases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide the ability for the consumer to specify a custom sort order in the list-races request or, by default, sort by the advertised start time.
Purpose
When listing events on a webpage, showing them in the order requested by the user or by default, time, would make the list easier to read.