Skip to content

chore(v1.33): tsc sweep + ops runbook covers multi-host + first-call + restart#107

Merged
masonwyatt23 merged 1 commit into
mainfrom
chore/v1.33-tsc-sweep-ops-docs
May 26, 2026
Merged

chore(v1.33): tsc sweep + ops runbook covers multi-host + first-call + restart#107
masonwyatt23 merged 1 commit into
mainfrom
chore/v1.33-tsc-sweep-ops-docs

Conversation

@masonwyatt23
Copy link
Copy Markdown
Member

Summary

  • Plugin tsc: 16 errors → 0. Test-only type annotation fixes; no production logic touched.
  • Server tsc: 0 errors (was already 0 once `bun install` ran).
  • `docs/operations.md`: 3 new subsections covering features landed in v1.33 waves 7-10.

Files fixed

File Cause Fix
`tests/cli-orchestrate.test.ts` 3 RunResult fixtures missing required `handoffsTruncated` field Add `handoffsTruncated: 0` to each
`tests/orchestrate-emit-telemetry.test.ts` `makeResult` partial overrides widened `maxConcurrentWindows` to undefined Add explicit `maxConcurrentWindows: []` + `handoffsTruncated: 0`
`tests/genome-cloud-sync.test.ts` `typeof fetch` requires `preconnect` but mock didn't have it Use structural `(url, init?) => Promise` to match `FetchFn`
`tests/orchestrate-retry-handoff.test.ts` `fn` typed as `ReturnType` (Subprocess) but `_setSpawnForTests` wants `typeof Bun.spawn` (the function) Change return-type annotation; mock impl already casts via `as any`
`site/app/source.ts` Auto-generated by `fumadocs-mdx` (`bun run gen-source`) — already wired into `package.json scripts.check` No change needed; verified clean after running the gen step

47 affected tests still pass.

docs/operations.md additions (3 new subsections)

  • "Running outside Claude Code" (under section 1 — Production topology): `ASHLR_MCP_HOST` matrix (claude-code / cline / claude-desktop / codex-cli / generic) + link to `docs/multi-host-mcp.md` + list of Claude-Code-only features that silently no-op on other hosts.
  • "First-call projection" (under section 5 — Logs + telemetry locations): one-shot celebration on first successful tool call, milestones flag at `~/.ashlr/milestones.json` (`first_call_celebrated`), dev test = `rm` the file and run a tool.
  • "F. 'I ran the wizard but the plugin doesn't seem to work'" (under section 6 — Common-fire troubleshooting): diagnose via `~/.ashlr/restart-required` (recent writtenAt + same pid = user missed restart); fix = `/quit` Claude Code, fully reopen, run a tool.

Test plan

  • `bunx tsc --noEmit` in repo root: 0 errors
  • `bunx tsc --noEmit` in `server/`: 0 errors (after `bun install`)
  • `bun test` on the 4 touched test files: 47/47 pass

🤖 Generated with Claude Code

…t-call + restart

Test-only type fixes — plugin tsc now 0 errors (was 16), server tsc unchanged at 0
once deps install. No production logic touched.

Tsc sweep:
- __tests__/cli-orchestrate.test.ts — add missing handoffsTruncated: 0 to 3
  RunResult fixtures.
- __tests__/orchestrate-emit-telemetry.test.ts — same, plus explicit
  maxConcurrentWindows: [] in makeResult so the partial override no longer widens
  the inferred type to undefined.
- __tests__/genome-cloud-sync.test.ts — replace typeof fetch annotation with the
  structural (url, init?) => Promise<Response> shape that matches FetchFn (no
  preconnect dependency).
- __tests__/orchestrate-retry-handoff.test.ts — fix mockSpawnQueued return type
  (typeof Bun.spawn, not ReturnType<>).
- site/app/source.ts: error is auto-generated dep miss, fixed by gen-source step
  already in package.json; no code change needed.

docs/operations.md additions:
- New "Running outside Claude Code" subsection under section 1 (topology) with the
  ASHLR_MCP_HOST matrix and a list of Claude-Code-only features.
- New "First-call projection" subsection at end of section 5 (logs/telemetry)
  documenting the milestones.json gate + dev-test reset.
- New troubleshooting entry F "I ran the wizard but the plugin doesn't seem to
  work" at end of section 6 covering ~/.ashlr/restart-required diagnosis.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ashlr-plugin-site Building Building Preview, Comment May 26, 2026 4:40am

Request Review

@masonwyatt23 masonwyatt23 merged commit 391e465 into main May 26, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant