Skip to content

Comments

Xpdf rc path Compatibility with Code Freezing Tools#4

Open
mush42 wants to merge 4 commits intoashutoshvarma:develfrom
blindpandas:xpdf_rc_path_fixes
Open

Xpdf rc path Compatibility with Code Freezing Tools#4
mush42 wants to merge 4 commits intoashutoshvarma:develfrom
blindpandas:xpdf_rc_path_fixes

Conversation

@mush42
Copy link

@mush42 mush42 commented Feb 15, 2021

Hi @ashutoshvarma

Changes

This PR makes generating xpdf_rc file path dynamic. The path is obtained using one of two methods:

  1. Environment variables (highest priority): if there is an environment variable named PYXPDF_RC_PATH it will be used.
  2. Using the appdirs package, we generate the file inside the Os specific user application config path taking care of returning a unique path per each instance (installation) of the pyxpdf_data package using a md5 hash of the poppler data path.

Rationale

The changes proposed in this PR are required to make the package compatible with code freezing tools such as PyInstaller as these tools disregard the site-packages directory, and package the stdlib as a zip file.

Best Regards,

ashutoshvarma and others added 4 commits August 31, 2020 10:48
…the pyxpdf_rc file based on the current location of the package. This make the package compatible with code freezing tools such as PyInstaller.

 * This commit adds a PyPI dep 'appdirs' to the pyxpdf_data package.
@ashutoshvarma
Copy link
Owner

Thanks for the PR @mush42! Also apologies for the late reply, It was a busy week for me.
I will try to review it by this weekend, hope you don't mind

@mush42
Copy link
Author

mush42 commented Mar 1, 2021

Hi @ashutoshvarma

Any news about the status of this PR?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants