Skip to content

fix(desktop): store preferences under Askimo home#537

Merged
haiphucnguyen merged 1 commit into
askimo-ai:mainfrom
AnayGarodia:fix/property-file-preferences
Jul 23, 2026
Merged

fix(desktop): store preferences under Askimo home#537
haiphucnguyen merged 1 commit into
askimo-ai:mainfrom
AnayGarodia:fix/property-file-preferences

Conversation

@AnayGarodia

Copy link
Copy Markdown
Contributor

What changed

  • replace Java Preferences storage with atomic plain .properties files under AskimoHome.base()
  • store application, per-account, and device preferences at the paths proposed in the issue
  • preserve typed getters, defaults, account isolation, and reset behavior
  • add tests covering paths, account ID sanitization, persistence, and device isolation

Verification

Using Temurin JDK 25, as required by the current Gradle toolchain:

  • ./gradlew :desktop-shared:test
  • ./gradlew :desktop-shared:spotlessCheck
  • ./gradlew :desktop-shared:detekt

All tasks completed successfully.

Closes #531

Signed-off-by: anay <agarodia98@gmail.com>
Copilot AI review requested due to automatic review settings July 22, 2026 22:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@CLAassistant

CLAassistant commented Jul 22, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@haiphucnguyen haiphucnguyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AnayGarodia !

@haiphucnguyen
haiphucnguyen merged commit d9fe723 into askimo-ai:main Jul 23, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize preferences storage paths across all platforms (macOS, Windows, Linux)

4 participants