Skip to content

fix(rag): explain missing embedding model setup - #552

Merged
haiphucnguyen merged 1 commit into
askimo-ai:mainfrom
w3lld1:fix/friendly-missing-embedding-model
Jul 24, 2026
Merged

fix(rag): explain missing embedding model setup#552
haiphucnguyen merged 1 commit into
askimo-ai:mainfrom
w3lld1:fix/friendly-missing-embedding-model

Conversation

@w3lld1

@w3lld1 w3lld1 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • I added an explicit check for a missing embedding model before provider initialization.
  • I replaced the low-level failure with guidance that points to the embedding-model setting.
  • I added a regression test for the user-facing message.

Validation

  • ./gradlew --no-daemon :cli:test --tests 'io.askimo.core.providers.EmbeddingModelConfigurationTest'
  • ./gradlew --no-daemon spotlessCheck -PspotlessRatchetFrom=upstream/main
  • git diff --check

The full multi-module test matrix is deferred to CI.

Fixes #549

Signed-off-by: w3lld1 <42353747+w3lld1@users.noreply.github.com>
@CLAassistant

CLAassistant commented Jul 24, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@haiphucnguyen

Copy link
Copy Markdown
Collaborator

Hi @w3lld1 , thank you for your PR. Can you sign the CLA?

@w3lld1

w3lld1 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Hi @w3lld1 , thank you for your PR. Can you sign the CLA?

done

@haiphucnguyen haiphucnguyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @w3lld1

@haiphucnguyen
haiphucnguyen merged commit f030c66 into askimo-ai:main Jul 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust the error message more user friendly

3 participants