Skip to content

Add bookmark support - #556

Merged
haiphucnguyen merged 2 commits into
askimo-ai:mainfrom
huynguyen20011:feature/add-message-bookmarks
Jul 25, 2026
Merged

Add bookmark support#556
haiphucnguyen merged 2 commits into
askimo-ai:mainfrom
huynguyen20011:feature/add-message-bookmarks

Conversation

@huynguyen20011

@huynguyen20011 huynguyen20011 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor
  • Add a dedicated bookmark view and components
  • Update localized texts

haiphucnguyen
haiphucnguyen reviewed Jul 25, 2026
View reviewed changes

@haiphucnguyen haiphucnguyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @huynguyen20011 for this PR. Leave the comment to request more testings

Comment thread shared/src/main/kotlin/io/askimo/core/chat/repository/ChatMessageRepository.kt
haiphucnguyen
haiphucnguyen reviewed Jul 25, 2026
View reviewed changes
Comment thread desktop-shared/src/main/resources/i18n/messages_vi_VN.properties
@haiphucnguyen

haiphucnguyen commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

When I toogle bookmark of in the chat view, but the bookmark badge in the navigation bar has not been changed. It would be nice if when we on/off bookmark item, we publish an event then the listener can consume and handle it

@haiphucnguyen

haiphucnguyen commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

When I toogle bookmark of in the chat view, but the bookmark badge in the navigation bar has not been changed. It would be nice if when we on/off bookmark item, we publish an event then the listener can consume and handle it

To keep this PR focused, we can move this to a follow-up ticket if you feel the current scope is becoming too large

haiphucnguyen
haiphucnguyen approved these changes Jul 25, 2026
View reviewed changes

@haiphucnguyen haiphucnguyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @huynguyen20011 for this great PR!

@haiphucnguyen
haiphucnguyen merged commit 95375fe into askimo-ai:main Jul 25, 2026
10 checks passed
@haiphucnguyen haiphucnguyen mentioned this pull request Jul 26, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haiphucnguyen haiphucnguyen haiphucnguyen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huynguyen20011 @haiphucnguyen