Add WinForms provider (+ sample app)#23
Merged
Merged
Conversation
asklar
force-pushed
the
feat/winforms-provider
branch
2 times, most recently
from
ff999ce to
a06ae6a
Compare
Adds WinForms detection, managed TAP-based HWND enrichment, a sample WinForms test app, and unit/integration coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
asklar
force-pushed
the
feat/winforms-provider
branch
from
a06ae6a to
aa4a57b
Compare
LvtWinFormsTap.csproj set PlatformTarget=AnyCPU but not an explicit OutputPath, so in a VS x64 developer environment (CI sets Platform=x64) MSBuild emitted the assembly to bin\x64\Release\ instead of bin\Release\. The native lvt_winforms_tap target copies from bin\Release\, so CI failed with "Error copying ... LvtWinFormsTap.dll: No such file or directory". Force a flat bin\<Config>\ output via explicit OutputPath so every invocation (ci.yml dotnet build, the CMake lvt_winforms_managed custom command, and plain local builds) lands the DLL where the copy expects it, regardless of the ambient Platform. Verified by reproducing Platform=x64 locally: the DLL now builds to bin\Release\ and lvt_winforms_tap's copy succeeds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #12
Deferred work: none for the vertical slice; future improvements could add more WinForms-specific properties beyond the common controls covered here.