Skip to content

#34 Commit the codes for fixing the lost records bug. #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TonnyAirFly wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#34 Commit the codes for fixing the lost records bug. #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .../src/main/java/com/askscio/atlassian_plugins/confluence/impl/ScioSearchServletFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,16 @@
@Named
public class ScioSearchServletFilter implements Filter {

private static final int NUM_BACKGROUND_THREADS = 1;
private static final int MAX_OUTSTANDING_REQUESTS = 10;
// Fix bug:
// [BUG] the plugin will lose some records with the station of high concurrency
// https://github.com/askscio/atlassian-plugins/issues/34
// This codes have been tested successfully in 16 cores and 256 GB memory. There is no data lost.
// huang.rong.gang@navercorp.com
private static final int NUM_BACKGROUND_THREADS = 32;
// private static final int NUM_BACKGROUND_THREADS = 1;

private static final int MAX_OUTSTANDING_REQUESTS = 5000;
// private static final int MAX_OUTSTANDING_REQUESTS = 10;
private static final int BASE_URL_MIN_PREFIX = "https://".length() + 1;

private static final Logger.Log logger = Logger.getInstance(ScioSearchServletFilter.class);
Expand Down