feat: add flag controlling the default for use_execroot_entry_point#2837
feat: add flag controlling the default for use_execroot_entry_point#2837acozzette wants to merge 4 commits into
Conversation
|
acozzette
force-pushed
the
use-execroot-entry-point
branch
2 times, most recently
from
62b523a to
810e38d
Compare
acozzette
force-pushed
the
use-execroot-entry-point
branch
2 times, most recently
from
20bcf8b to
b0bcf10
Compare
This change introduces the flag `--@aspect_rules_js//js:use_execroot_entry_point`, which controls the default behavior of the `use_execroot_entry_point` option on `js_run_binary` and `js_run_devserver`. We could like to recommend moving away from enabling `use_execroot_entry_point`, and this flag provides an easy way to do that at a global level, while still making it possible to override that on specific targets if necessary. I also added CI test runs with `--@aspect_rules_js//js:use_execroot_entry_point=False` so that we have good test coverage of both modes. This required explicitly setting `use_execroot_entry_point` on some targets that only work with one more or the other. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
acozzette
force-pushed
the
use-execroot-entry-point
branch
from
b0bcf10 to
50ba91b
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6ed12806e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "no-remote-exec", | ||
| ], | ||
| tool = ":jasmine", | ||
| use_execroot_entry_point = True, |
There was a problem hiding this comment.
Is this an example where the tool should be updated to support False instead? Maybe just leave a TODO here for now and come back to it later?
2 participants
This change introduces the flag
--@aspect_rules_js//js:use_execroot_entry_point, which controls the default behavior of theuse_execroot_entry_pointoption onjs_run_binaryandjs_run_devserver.We could like to recommend moving away from enabling
use_execroot_entry_point, and this flag provides an easy way to do that at a global level, while still making it possible to override that on specific targets if necessary.I also added CI test runs with
--@aspect_rules_js//js:use_execroot_entry_point=Falseso that we have good test coverage of both modes. This required explicitly settinguse_execroot_entry_pointon some targets that only work with one more or the other.Changes are visible to end-users: yes
There is now a
--@aspect_rules_js//js:use_execroot_entry_pointflag which can be set toTrueorFalseto determine the defaultuse_execroot_entry_pointbehavior.Test plan