Skip to content

Add .php as code bearing extension - #47

Merged
mvoutov merged 1 commit into
aspenkit:mainfrom
ThomasOosterbeek:php-code-bearing
Jul 21, 2026
Merged

Add .php as code bearing extension#47
mvoutov merged 1 commit into
aspenkit:mainfrom
ThomasOosterbeek:php-code-bearing

Conversation

@ThomasOosterbeek

@ThomasOosterbeek ThomasOosterbeek commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

What

Add '.php' as a code bearing extension.

Why

Php file changes were not being recognized as code bearing resulting in them being ignored when running doc sync.
'composer.lock' is present in the lock files so it was likely forgotten.

How I tested

  • npm test passes
  • Tested against a real repo
  • --dry-run output looks correct (if applicable)

Checklist

  • Changes are focused on a single feature or fix
  • Tests added or updated for any logic changes
  • No new dependencies added (or justified in the PR description)

Summary by CodeRabbit

  • Bug Fixes
    • PHP file changes are now correctly recognized as meaningful code changes rather than no-op updates.
  • Tests
    • Expanded coverage to verify correct classification of PHP-only changes.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 14873080-d7f2-44b3-a028-b0f3ef1dd3f7

📥 Commits

Reviewing files that changed from the base of the PR and between 0c24595 and 8e6c925.

📒 Files selected for processing (2)
  • src/lib/diff-classifier.js
  • tests/diff-classifier.test.js

Walkthrough

The diff classifier now treats .php files as code-bearing, and the existing test iterates over .php to verify non-no-op classification.

Changes

Diff classification

Layer / File(s) Summary
Recognize PHP code files
src/lib/diff-classifier.js, tests/diff-classifier.test.js
Adds .php to the code-bearing extension set and extends the single-file classification test accordingly.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: adding .php as a code-bearing extension.
Description check ✅ Passed The description follows the template and covers What, Why, How I tested, and the checklist with relevant details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mvoutov

mvoutov commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@ThomasOosterbeek looks great. Thanks for your contribution!

@mvoutov
mvoutov merged commit fc9abb7 into aspenkit:main Jul 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants