Skip to content

Apply Rector fixes, add PHPStan baseline #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylfabre merged 4 commits into from
Feb 14, 2026
Merged

Apply Rector fixes, add PHPStan baseline #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04e2157
Apply Rector fixes and add PHPStan baseline for denormalize covariance
sylfabre Feb 13, 2026
99d748b
Fix CRLF line endings to LF
sylfabre Feb 13, 2026
e1bca5a
Fix denormalize return type properly, remove baseline, add trailing n…
sylfabre Feb 14, 2026
711eab9
Restore AbsolutePercentValue return type with phpstan-ignore
sylfabre Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ parameters:
- tests/

includes:
- vendor/assoconnect/php-quality-config/phpstan.extension.neon
- vendor/assoconnect/php-quality-config/phpstan.extension.neon
4 changes: 1 addition & 3 deletions src/Normalizer/AbsolutePercentValueNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,8 @@
return $data instanceof AbsolutePercentValue;
}

/**
* @inheritDoc
*/
/** @phpstan-ignore method.childReturnType */
public function denormalize(

Check failure on line 51 in src/Normalizer/AbsolutePercentValueNormalizer.php

View workflow job for this annotation

GitHub Actions / build (8.4, lowest) 

No error with identifier method.childReturnType is reported on line 51.

Check failure on line 51 in src/Normalizer/AbsolutePercentValueNormalizer.php

View workflow job for this annotation

GitHub Actions / build (8.4, lowest) 

Method AssoConnect\AbsolutePercentValueBundle\Normalizer\AbsolutePercentValueNormalizer::denormalize() has parameter $context with no value type specified in iterable type array.

Check failure on line 51 in src/Normalizer/AbsolutePercentValueNormalizer.php

View workflow job for this annotation

GitHub Actions / build (8.3, lowest) 

No error with identifier method.childReturnType is reported on line 51.

Check failure on line 51 in src/Normalizer/AbsolutePercentValueNormalizer.php

View workflow job for this annotation

GitHub Actions / build (8.3, lowest) 

Method AssoConnect\AbsolutePercentValueBundle\Normalizer\AbsolutePercentValueNormalizer::denormalize() has parameter $context with no value type specified in iterable type array.
mixed $data,
string $type,
?string $format = null,
Expand Down
6 changes: 3 additions & 3 deletions tests/Normalizer/AbsolutePercentValueNormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ protected function setUp(): void
}

/** @return iterable<mixed> */
public function providerSupportsNormalization(): iterable
public static function providerSupportsNormalization(): iterable
{
yield [new AbsolutePercentValue(AbsolutePercentValue::TYPE_ABSOLUTE, '20000'), true];
yield [new \stdClass(), false];
Expand Down Expand Up @@ -49,7 +49,7 @@ public function testNormalize(): void
}

/** @return iterable<mixed> */
public function providerSupportsDenormalization(): iterable
public static function providerSupportsDenormalization(): iterable
{
yield [AbsolutePercentValue::class, true];
yield [\stdClass::class, false];
Expand All @@ -73,7 +73,7 @@ public function testDenormalizeFailure(mixed $data): void
}

/** @return iterable<mixed> */
public function providerTestDenormalize(): iterable
public static function providerTestDenormalize(): iterable
{
yield [''];
yield [null];
Expand Down
2 changes: 1 addition & 1 deletion tests/Object/AbsolutePercentValueTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public function testConstructSuccess(string $type): void
}

/** @return iterable<mixed> */
public function providerTypes(): iterable
public static function providerTypes(): iterable
{
yield [AbsolutePercentValue::TYPE_PERCENT];
yield [AbsolutePercentValue::TYPE_ABSOLUTE];
Expand Down
Loading