Add DBAL 4 support alongside DBAL 3.6 - #38
Merged
Merged
Conversation
fguimier
commented
Jul 16, 2026
fguimier
commented
Contributor
- doctrine/dbal constraint: ^2.8|^3.0 -> ^3.6|^4.0 (CI lowest/highest now covers both majors)
- ramsey/uuid-doctrine: ^1.4 -> ^1.4|^2.0
- AbstractFixedLengthStringType: getVarcharTypeDeclarationSQL() -> getStringTypeDeclarationSQL() (removed in DBAL 4, available since 3.4)
- DateTimeImmutableMicroSecondsType: ConversionException static factories are DBAL 3 only; use Types\Exception{InvalidFormat,InvalidType} when available (DBAL 4)
- getName() and requiresSQLCommentHint() overrides kept while DBAL 3 is supported
- Tests: replace removed getMockForAbstractClass() with createStub/createMock, @dataProvider annotations -> attributes (PHPUnit 13), drop unused doctrine/cache + doctrine/annotations dev deps
- doctrine/dbal constraint: ^2.8|^3.0 -> ^3.6|^4.0 (CI lowest/highest now covers both majors)
- ramsey/uuid-doctrine: ^1.4 -> ^1.4|^2.0
- AbstractFixedLengthStringType: getVarcharTypeDeclarationSQL() -> getStringTypeDeclarationSQL() (removed in DBAL 4, available since 3.4)
- DateTimeImmutableMicroSecondsType: ConversionException static factories are DBAL 3 only; use Types\Exception\{InvalidFormat,InvalidType} when available (DBAL 4)
- getName() and requiresSQLCommentHint() overrides kept while DBAL 3 is supported
- Tests: replace removed getMockForAbstractClass() with createStub/createMock, @dataProvider annotations -> attributes (PHPUnit 13), drop unused doctrine/cache + doctrine/annotations dev deps
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Add missing tests: getName(), getSQLDeclaration() (DATETIME(3) + TIMESTAMP version column), convertToDatabaseValue(null), and convertToPHPValue() with an exact 'Y-m-d H:i:s.v' string (createFromFormat success path) - Exclude the DBAL version-conditional exception factories from coverage: only one branch can ever run for a given installed DBAL major - Type the test property with the concrete class (adds null-safety assertions required by phpstan) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.