Rolling horizon dsm#804
Conversation
…o rolling_horizon_dsm
…o rolling_horizon_dsm Co-authored-by: Copilot <copilot@github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
- Coverage 80.79% 80.40% -0.40%
==========================================
Files 56 56
Lines 8676 9252 +576
==========================================
+ Hits 7010 7439 +429
- Misses 1666 1813 +147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maurerle
left a comment
There was a problem hiding this comment.
I did not review the dsm_load_shift.py - but all other files.
There are still a few things to do.
I guess that the way in which units are added to the DSMFlex is not that good, as the code seems to not know which parameters of the class exist.
The result is the need for various hasattr checks, as you never know if a param exists or is initialized.
I suggest using planning mode and a larger context window when using an LLM to help with this..
|
|
||
| # Set the congestion_indicator in the instance | ||
| # Delete the old component if it exists to avoid Pyomo warnings | ||
| if hasattr(instance, "congestion_indicator"): |
There was a problem hiding this comment.
I don't like this check - can't we test for something like instance.flexibility_measure == "congestion_management_flexibility" in which case the congestion_indicator is set?
This is more like a general thing
Co-authored-by: Copilot <copilot@github.com>
|
@Manish-Khanra please rebase/merge and fix the conflicts - then this can be merged :) |
Related Issue
Closes #804
If no issue exists, delete this line.
Description
This PR implements rolling-horizon optimization for the DSM units, enabling reactive bidding while maintaining inter-temporal feasibility. Previously, DSM units (steel plants, buildings, hydrogen plants, steam generation plants) optimized over the full simulation horizon. This feature allows units to re-optimize shorter look-ahead windows after each market round while carrying forward component states (e.g., storage SoC, operational status).
Checklist
docfolder updates etc.)Additional Notes (optional)
Key Features
dsm_optimisation_configwithhorizon_mode,look_ahead_horizon,commit_horizon, androlling_stepkeys