RMA-101184: code changes in halstack lib#159
RMA-101184: code changes in halstack lib#159smishra367 wants to merge 27 commits intofeature/AssureClaimsfrom
Conversation
216 build server not supported the NPM and Node and NVM versions. Hence not able to continue our build process...
Update package.json
Update package.json
Feature/rma 98688 Multiline labels
multiline label issue
…halstack-angular into feature/RMA-100989
Feature/rma 100989
feature/RMA-101210: checkin on behalf of vishal
assureclaims
left a comment
assureclaims
left a comment
There was a problem hiding this comment.
still code is missed for supporting reactive form
There was a problem hiding this comment.
IfileuploadRequest check the case - Change it to IFileUploadRequest
There was a problem hiding this comment.
use camel case for all properties and functions name
global_filehit: number = 0; should be like globalFileHit
global_chunkcount: number = 0;
global_actualchunkcount: number = 0;
filedataupload: filemetadata;
GUID: string;
fileEventType: EventType = EventType.PREUPLOAD;
chunkresult: boolean;
Postresp: any;
| // }); | ||
| this.uploadChunkDoc(eventFiles); | ||
| } | ||
| uploadChunkDoc(file) { |
There was a problem hiding this comment.
should be private if not calling from html
There was a problem hiding this comment.
filemetadata should be pascal case FileMetadata
There was a problem hiding this comment.
why copied the configuration model file in side dxc-file-input
There was a problem hiding this comment.
changes the name of file this is not a service file this is models related to file upload component. and move the file in modles folder
There was a problem hiding this comment.
why copy the lookupmodel in side dxc-file input ?
There was a problem hiding this comment.
why copy the lookup.ts in side dxc-file input ?
projects/dxc-ngx-cdk/src/lib/dxc-file-input/dxc-file-input.component.ts
Outdated
Show resolved
Hide resolved
projects/dxc-ngx-cdk/src/lib/dxc-file-input/dxc-file-input.component.ts
Outdated
Show resolved
Hide resolved
projects/dxc-ngx-cdk/src/lib/dxc-file-input/dxc-file-input.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
uploadcomplete still not camel case
5 participants
RMA-101184