Fix/738 scraper viewmodel dbcontext lifetime#740
Merged
astar-development-jb merged 3 commits intoJul 12, 2026
Conversation
…actor - Tests expect LoadAsync/SaveAsync to accept CancellationToken - Tests expect methods to return Result<Unit, ScrapeError> - Tests verify per-operation DbContext usage - Tests verify token propagation - Tests verify manager.ReloadAsync is called
… skips CancellationToken propagation
astar-development-jb
enabled auto-merge (squash)
July 12, 2026 05:13
astar-development-jb
approved these changes
Jul 12, 2026
astar-development-jb
deleted the
fix/738-scraper-viewmodel-dbcontext-lifetime
branch
July 12, 2026 05:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve ScrapeConfigurationViewModel holds a long-lived DbContext and skips CancellationToken propagation
Type of change
Related issues / links
Closes #768
How was this tested?
Impacted areas
Scrapper app
TDD Checklist (required)
dotnet test)How to run tests locally
Notes for reviewers