docs: codify recurring Phase 0-3 review findings as agent rules#73
Merged
Conversation
- CLAUDE.md: REFACTOR RULES section — behaviour-frozen definition (concurrency, exception types, error paths) + mandatory declared, test-pinned, approved DEVIATIONS - c-sharp-dev: pre-report self-review checklist (consistency sweep, guards on new public APIs, factory-over-ctor, mirror-type parity, DEVIATIONS section) - c-sharp-qa: freeze tests pin exception types/error paths; new constants classes get pinning tests Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
astar-development-jb
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Analysis of c-sharp-reviewer findings across Phases 0–3 (PRs #69–#72) showed four repeated mistake classes. This codifies them as rules so the agents stop repeating them:
Task.WhenAllhref fetch, empty-header error path, exception-type change; Phase 0: unreproducible B5 claim) → newREFACTOR RULESsection in CLAUDE.md: frozen = no observable change incl. concurrency/exception types/error paths; deviations must be test-pinned, declared in a DEVIATIONS section, and approved.var/ConfigureAwaitinconsistency) → full-diff grep sweep required before the dev agent reports done.ExceptionalTask-receiver overloads; Phase 2 untested constants) → parity-diff checklist item for dev; c-sharp-qa rule: freeze tests pin exception types/error paths, constants get pinning tests.Test plan
dotnet buildunaffected🤖 Generated with Claude Code