Phase 5: workflow unification via PagedScrapeRunner (functional refactor plan)#75
Merged
Merged
Conversation
…tion TDD red state: tests pin PagedScrapeRunner/PagedScrapePlan, Result-based SubscriptionsWorkflow/TopWallpapersWorkflow, configured PageNavigation delay. Build fails only on the not-yet-existing Phase 5 types. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…lan) - New PagedScrapeRunner + PagedScrapePlan: shared page loop (delay -> record progress -> save config -> load page -> get links -> process) - SubscriptionsWorkflow and TopWallpapersWorkflow refactored to the Phase 4 shape: Result<Unit, ScrapeError> RunAsync, injected IDelayStrategy, Serilog.ILogger; frozen quirks preserved - SearchWorkflow page loop delegates to the runner - DelayKind.PageNavigation now configuration-driven (ImagePauseInSeconds) per plan decision; ScrapperConstants.PageNavigationDelay removed - Workflows + SearchConfiguration registered in DI, resolution pinned by tests Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
astar-development-jb
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 5 of
docs/wallpaper-scrapper-functional-refactor-plan.md: SubscriptionsWorkflow and TopWallpapersWorkflow refactored to the Phase 4 SearchWorkflow shape, with the shared page loop extracted into a single genericPagedScrapeRunner.PagedScrapeRunner+PagedScrapePlan— one page-loop skeleton (cancel check → delay → record progress → save config → load page → get links → process links, fail-fast on first failure); the three workflows are now thin configurations of it.Task<Result<Unit, ScrapeError>> RunAsync, injectedIDelayStrategy,Serilog.ILogger, failures logged viaLogFailureand returned instead of thrown. Frozen quirks preserved: reset-to-page-1 + retry-once initial load, discarded per-page-load results, post-loop clear-all when PageCount > 0.DelayKind.PageNavigationnow derives from configuration (ImagePauseInSeconds) per plan decision §2; hard-coded 2sScrapperConstants.PageNavigationDelayremoved.PagedScrapeRunner+SearchConfigurationregistered; resolvability pinned by new tests (UI wiring stays out of scope per plan).Deviations (plan-approved)
InvalidOperationExceptionin the two workflows.PageNavigationdelay: fixed 2s → configuredImagePauseInSecondswindow.Serilog.Core.Logger→Serilog.ILogger.ct.ThrowIfCancellationRequested()(pinned by test; same exception semantics).Test plan
dotnet test AStar.Dev.Web.Scrapper.slnx: 583 passed, 1 pre-existing skip, 0 failed.SearchConfigurationin DI) fixed + regression-tested.🤖 Generated with Claude Code