Skip to content

Phase 6 MainWindow composition#76

Merged
astar-development-jb merged 4 commits into
mainfrom
phase-6-mainwindow-composition
Jul 6, 2026
Merged

Phase 6 MainWindow composition#76
astar-development-jb merged 4 commits into
mainfrom
phase-6-mainwindow-composition

Conversation

@jbarden

@jbarden jbarden commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR completes the Phase 6 MainWindow composition work by tightening the UI workflow startup path, validating scrape configuration at startup, and registering the new view factory helpers used by the composed views.

Type of change

  • Feature
  • Bug fix
  • Refactor
  • CI/CD
  • Documentation
  • Maintenance

Related issues / links

How was this tested?

  • Unit tests added/updated
  • Manual validation
  • Not applicable

Impacted areas

  • src/AStar.Dev.Wallpaper.Scrapper
  • test/AStar.Dev.Wallpaper.Scrapper.Tests.Unit

TDD Checklist (required)

  • Builds locally
  • Tests pass (dotnet test)
  • No new analyzer warnings
  • Public API changes reviewed
  • Documentation updated (if applicable)
  • Not applicable

How to run tests locally

# Restore and run tests
dotnet restore AStar.Dev.Web.Scrapper.slnx
dotnet test --verbosity normal

Notes for reviewers

  • Ensure CI passed for all OS runners where configured.

jaybarden1 and others added 3 commits July 6, 2026 20:06
…config validator, view factories)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- ScrapeSiteWorkflowDecision generalised to DecideAsync<TResult>; Tags/Classifications/ScrapeConfiguration views now use the same short-circuit + try/finally ResetUI treatment as MainWindow (cts!.Token reads removed)
- App startup: blocking Task.Run(...).GetAwaiter().GetResult() replaced with async initialisation (window shown explicitly once init completes)
- View + Func<TView> factory registrations collapsed into AddViewFactory<TView>()
- ScrapeConfiguration validated at startup via Validation<T>; all errors broadcast to the UI status log
- Validation<T> gains Match extension

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jbarden jbarden requested a review from a team July 6, 2026 19:46
@astar-development-jb astar-development-jb enabled auto-merge (squash) July 6, 2026 19:47
@astar-development-jb astar-development-jb merged commit 120f7e7 into main Jul 6, 2026
6 checks passed
@astar-development-jb astar-development-jb deleted the phase-6-mainwindow-composition branch July 6, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants