Phase 6 MainWindow composition#76
Merged
Merged
Conversation
…config validator, view factories) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- ScrapeSiteWorkflowDecision generalised to DecideAsync<TResult>; Tags/Classifications/ScrapeConfiguration views now use the same short-circuit + try/finally ResetUI treatment as MainWindow (cts!.Token reads removed) - App startup: blocking Task.Run(...).GetAwaiter().GetResult() replaced with async initialisation (window shown explicitly once init completes) - View + Func<TView> factory registrations collapsed into AddViewFactory<TView>() - ScrapeConfiguration validated at startup via Validation<T>; all errors broadcast to the UI status log - Validation<T> gains Match extension Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
astar-development-jb
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the Phase 6 MainWindow composition work by tightening the UI workflow startup path, validating scrape configuration at startup, and registering the new view factory helpers used by the composed views.
Type of change
Related issues / links
How was this tested?
Impacted areas
TDD Checklist (required)
dotnet test)How to run tests locally
Notes for reviewers