Skip to content

Add cancellation token to the PlaywrightService.#19

Merged
astar-development-jb merged 1 commit into
mainfrom
chore/add-cancellation-to-playwright-service
Jul 14, 2026
Merged

Add cancellation token to the PlaywrightService.#19
astar-development-jb merged 1 commit into
mainfrom
chore/add-cancellation-to-playwright-service

Conversation

@jbarden

@jbarden jbarden commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Add cancellation token to the PlaywrightService.

Update App config to support overriding the appsettings in the tests - it was working but by luck, now the order of appsetting application is deterministic

Type of change

  • Feature
  • Bug fix
  • Refactor
  • CI/CD
  • Documentation
  • Maintenance

Related issues / links

None

How was this tested?

  • Unit tests added/updated
  • Manual validation
  • Not applicable

Impacted areas


TDD Checklist (required)

  • Builds locally
  • Tests pass (dotnet test)
  • No new analyzer warnings
  • Public API changes reviewed
  • Documentation updated (if applicable)
  • Not applicable

How to run tests locally

# Restore and run tests
dotnet restore AStar.Dev.slnx
dotnet test --verbosity normal

Notes for reviewers

  • Ensure CI passed for all OS runners where configured.

Update App config to support overriding the appsettings in the tests - it was working but by luck, now the order of appsetting application is deterministic
@jbarden
jbarden requested a review from a team July 14, 2026 16:18
@astar-development-jb
astar-development-jb enabled auto-merge (squash) July 14, 2026 16:19
@astar-development-jb
astar-development-jb merged commit 1eac70c into main Jul 14, 2026
4 checks passed
@astar-development-jb
astar-development-jb deleted the chore/add-cancellation-to-playwright-service branch July 14, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants