Skip to content

feat: remove ScrapeConfiguration table and fold its columns into depe…#21

Merged
astar-development-jb merged 1 commit into
mainfrom
feature/remove-scrape-configuration-table
Jul 14, 2026
Merged

feat: remove ScrapeConfiguration table and fold its columns into depe…#21
astar-development-jb merged 1 commit into
mainfrom
feature/remove-scrape-configuration-table

Conversation

@jbarden

@jbarden jbarden commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

…ndent entities

Drops the standalone ScrapeConfigurationEntity/FK now that ConnectionStrings, SearchConfiguration, UserConfiguration and ScrapeDirectories own their own rows directly, removing an unnecessary join.

Type of change

  • Feature
  • Bug fix
  • Refactor
  • CI/CD
  • Documentation
  • Maintenance

Related issues / links

None

How was this tested?

  • Unit tests added/updated
  • Manual validation
  • Not applicable

Impacted areas

Scraper app dB


TDD Checklist (required)

  • Builds locally
  • Tests pass (dotnet test)
  • No new analyzer warnings
  • Public API changes reviewed
  • Documentation updated (if applicable)
  • Not applicable

How to run tests locally

# Restore and run tests
dotnet restore AStar.Dev.slnx
dotnet test --verbosity normal

Notes for reviewers

  • Ensure CI passed for all OS runners where configured.

…ndent entities

Drops the standalone ScrapeConfigurationEntity/FK now that ConnectionStrings,
SearchConfiguration, UserConfiguration and ScrapeDirectories own their own rows
directly, removing an unnecessary join.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@jbarden
jbarden requested a review from a team July 14, 2026 20:54
@astar-development-jb
astar-development-jb enabled auto-merge (squash) July 14, 2026 20:54
@astar-development-jb
astar-development-jb merged commit 05212cb into main Jul 14, 2026
4 checks passed
@astar-development-jb
astar-development-jb deleted the feature/remove-scrape-configuration-table branch July 14, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants