Open
Conversation
osmanhadzic
force-pushed
the
end2endtests
branch
from
c398cfa to
bdbb2d0
Compare
harlem88
requested changes
Dec 5, 2023
DeviceSDK/src/main/java/org/astarteplatform/devicesdk/AstartePairingService.java
Show resolved
Hide resolved
...icTest/src/main/java/org/astarteplatform/devicesdk/tests/e2etest/GenericAggregateDevice.java
Outdated
Show resolved
Hide resolved
...icTest/src/main/java/org/astarteplatform/devicesdk/tests/e2etest/GenericAggregateDevice.java
Outdated
Show resolved
Hide resolved
...icTest/src/main/java/org/astarteplatform/devicesdk/tests/e2etest/GenericAggregateDevice.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/astarteplatform/devicesdk/tests/e2etest/utilities/GenericMockDevice.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/astarteplatform/devicesdk/tests/e2etest/utilities/GenericMockDevice.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/astarteplatform/devicesdk/tests/e2etest/utilities/GenericDeviceMockData.java
Outdated
Show resolved
Hide resolved
osmanhadzic
force-pushed
the
end2endtests
branch
from
bdbb2d0 to
d90cd84
Compare
lucaato
reviewed
Dec 7, 2023
Collaborator
lucaato
left a comment
lucaato
left a comment
There was a problem hiding this comment.
I reviewed some files, let me know what you think about the comments.
...t/src/main/java/org/astarteplatform/devicesdk/tests/e2etest/utilities/GenericMockDevice.java
Outdated
Show resolved
Hide resolved
...ain/java/org/astarteplatform/devicesdk/tests/e2etest/utilities/GenericInterfaceProvider.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/astarteplatform/devicesdk/tests/e2etest/utilities/AstarteHttpRequest.java
Outdated
Show resolved
Hide resolved
...java/org/astarteplatform/devicesdk/tests/e2etest/utilities/GenericDeviceMockDataFactory.java
Outdated
Show resolved
Hide resolved
osmanhadzic
force-pushed
the
end2endtests
branch
from
d90cd84 to
e613800
Compare
Signed-off-by: Osman Hadzic <osman.hadzic@secomind.com>
osmanhadzic
force-pushed
the
end2endtests
branch
from
e613800 to
4f847fb
Compare
lucaato
reviewed
Dec 23, 2024
Comment on lines
+69
to
+74
| sudo openssl s_client -connect api.autotest.astarte-platform.org:443 -showcerts </dev/null 2>/dev/null|openssl x509 -outform PEM > ${GITHUB_WORKSPACE}/astarte-certificates.pem | ||
| openssl x509 -outform der -in ${GITHUB_WORKSPACE}/astarte-certificates.pem -out ${GITHUB_WORKSPACE}/astarte-certificates.der | ||
| echo $JAVA_HOME | ||
| KEYSTORE_PATH=$JAVA_HOME/lib/security/cacerts | ||
| sudo keytool -import -noprompt -trustcacerts -alias "astarteroot-cert" -file ${GITHUB_WORKSPACE}/astarte-certificates.der -keystore $KEYSTORE_PATH -storepass changeit | ||
| sudo keytool -keystore $KEYSTORE_PATH -storepass changeit -list | grep astarteroot-cert |
Collaborator
There was a problem hiding this comment.
This could probably be simplified, I don't think you need to generate a new certificate. A valid certificate is already generated at the /usr/local/share/ca-certificates/astarte-autotest.crt path by the astarte-cluster-action. You should be able to import this one directly in the jvm key store.
Author
There was a problem hiding this comment.
I had a lot of problems when I tried to create an end-to-end test for Java. The problem was related to SSL certification because our master branch does not have a flag to avoid SSL errors. I found a solution to fix the error. The solution was to add the SSL key to the JVM.
Collaborator
|
There are also a number of exception thrown and logged in the e2e test build and run step, you should probably take a look at those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add end-to-end test for:
Send property from device to server and from server to device
Send Datastream from device to server and from server to device
Send Aggregate data from device to server and from server to device
Closes: #54