Conversation
Member
|
Seems good so far! Beside the padding issue, the only thing I noticed is that the animation doesn't run quite smoothly. See the following Screenrecording. Can you fix this? |
domai-tb
requested changes
Oct 7, 2025
Member
domai-tb
left a comment
domai-tb
left a comment
There was a problem hiding this comment.
Animation should be smoother
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the home bottom navigation bar to display a fixed window of 5 icons and animate the visible set horizontally, while keeping existing page-selection callbacks and label behavior.
Changes:
- Reworked
BottomNavBarto clip to 5 visible items and animate between window positions. - Updated
BottomNavBarItemlayout/padding and label rendering (single-line, no-wrap when active). - Standardized multiple icon
Image.assetusages tofilterQuality: FilterQuality.none.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/utils/widgets/subpage_button.dart | Adjusts asset image filter quality for leading icon rendering. |
| lib/utils/widgets/campus_icon_button.dart | Sets filter quality for raster icons in the reusable icon button. |
| lib/pages/more/widgets/external_link_button.dart | Adjusts asset image filter quality for leading icon rendering. |
| lib/pages/home/widgets/side_nav_bar_item.dart | Adjusts asset image filter quality for side-nav icons. |
| lib/pages/home/widgets/bottom_nav_bar_item.dart | Tweaks icon padding/animation and switches label to an AnimatedSwitcher single-line text. |
| lib/pages/home/widgets/bottom_nav_bar.dart | Implements the 5-icon visible window, safe-area-aware sizing, and animated transitions between window positions. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
What the fuck... All automatic rules for Copilot should be disabled... |
github-project-automation
Bot
moved this from In progress
to Done
in Campus App by AStA Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render exactly 5 bottom-nav icons at rest and animate the visible window with a smooth horizontal slide; preserves existing callbacks and label behavior.