Add the ability to dynamically select Platform Type #257
Conversation
Summary of ChangesHello @AntonKun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the application's configurability by enabling dynamic selection of the WhatsApp session's platform type. Users can now specify whether their session appears as a desktop, iPad, Android phone, or other device types to WhatsApp, which can influence the session's display and behavior within the WhatsApp ecosystem. This functionality is exposed through both a new command-line flag and an environment variable, offering versatile deployment options. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to dynamically configure the platform type, which is a useful enhancement. The implementation is straightforward, adding a new command-line flag and an environment variable. My main feedback is on the new getPlatformTypeEnum function, which can be significantly simplified and made more maintainable by leveraging the auto-generated map from the protobuf definition instead of a large switch statement. This will make the code more robust to future changes in the underlying library.
| platformType = strings.ToUpper(strings.TrimSpace(platformType)) | ||
|
|
||
| switch platformType { | ||
| case "UNKNOWN": | ||
| return waCompanionReg.DeviceProps_UNKNOWN.Enum() | ||
| case "CHROME": | ||
| return waCompanionReg.DeviceProps_CHROME.Enum() | ||
| case "FIREFOX": | ||
| return waCompanionReg.DeviceProps_FIREFOX.Enum() | ||
| case "IE": | ||
| return waCompanionReg.DeviceProps_IE.Enum() | ||
| case "OPERA": | ||
| return waCompanionReg.DeviceProps_OPERA.Enum() | ||
| case "SAFARI": | ||
| return waCompanionReg.DeviceProps_SAFARI.Enum() | ||
| case "EDGE": | ||
| return waCompanionReg.DeviceProps_EDGE.Enum() | ||
| case "DESKTOP": | ||
| return waCompanionReg.DeviceProps_DESKTOP.Enum() | ||
| case "IPAD": | ||
| return waCompanionReg.DeviceProps_IPAD.Enum() | ||
| case "ANDROID_TABLET": | ||
| return waCompanionReg.DeviceProps_ANDROID_TABLET.Enum() | ||
| case "OHANA": | ||
| return waCompanionReg.DeviceProps_OHANA.Enum() | ||
| case "ALOHA": | ||
| return waCompanionReg.DeviceProps_ALOHA.Enum() | ||
| case "CATALINA": | ||
| return waCompanionReg.DeviceProps_CATALINA.Enum() | ||
| case "TCL_TV": | ||
| return waCompanionReg.DeviceProps_TCL_TV.Enum() | ||
| case "IOS_PHONE": | ||
| return waCompanionReg.DeviceProps_IOS_PHONE.Enum() | ||
| case "IOS_CATALYST": | ||
| return waCompanionReg.DeviceProps_IOS_CATALYST.Enum() | ||
| case "ANDROID_PHONE": | ||
| return waCompanionReg.DeviceProps_ANDROID_PHONE.Enum() | ||
| case "ANDROID_AMBIGUOUS": | ||
| return waCompanionReg.DeviceProps_ANDROID_AMBIGUOUS.Enum() | ||
| case "WEAR_OS": | ||
| return waCompanionReg.DeviceProps_WEAR_OS.Enum() | ||
| case "AR_WRIST": | ||
| return waCompanionReg.DeviceProps_AR_WRIST.Enum() | ||
| case "AR_DEVICE": | ||
| return waCompanionReg.DeviceProps_AR_DEVICE.Enum() | ||
| case "UWP": | ||
| return waCompanionReg.DeviceProps_UWP.Enum() | ||
| case "VR": | ||
| return waCompanionReg.DeviceProps_VR.Enum() | ||
| default: | ||
| log.Warn().Str("platformType", platformType).Msg("Unknown platform type, defaulting to DESKTOP") | ||
| return waCompanionReg.DeviceProps_DESKTOP.Enum() | ||
| } |
There was a problem hiding this comment.
The getPlatformTypeEnum function can be made more concise and maintainable. The waCompanionReg package, which is generated from a protobuf definition, provides a DeviceProps_PlatformType_value map that translates platform type names (strings) to their integer values. Using this map instead of a large switch statement will simplify the code and ensure it automatically supports new platform types if the underlying protobuf definition is updated.
platformType = strings.ToUpper(strings.TrimSpace(platformType))
if val, ok := waCompanionReg.DeviceProps_PlatformType_value[platformType]; ok {
enumVal := waCompanionReg.DeviceProps_PlatformType(val)
return enumVal.Enum()
}
log.Warn().Str("platformType", platformType).Msg("Unknown platform type, defaulting to DESKTOP")
return waCompanionReg.DeviceProps_DESKTOP.Enum()1 participant
I added the ability to dynamically set the Platform Type, the value of which affects the display of the session in the WhatsApp application.