Rewrite the native authentication storage scheme#18907
Draft
Conversation
zanieb
force-pushed
the
zb/native-auth-as-json
branch
from
d3b24eb to
e4b5978
Compare
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
Contributor
|
Sorry for the confusion - I'm @oshadha-dev and was using an assistant to help review the code. The approval was submitted in error. I was analyzing the PR but the formal approval should not have been submitted. Please disregard it! |
Contributor
|
Hey @zanieb - the implementation looks good and should fix the artifactory issue. (Apologies for the accidental approval earlier - that was submitted in error) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.