Show larger files first in progress reporters#18918
Open
zanieb wants to merge 2 commits intoastral-sh:mainfrom
Open
Show larger files first in progress reporters#18918zanieb wants to merge 2 commits intoastral-sh:mainfrom
zanieb wants to merge 2 commits intoastral-sh:mainfrom
Conversation
Previously, progress bars were inserted at a position determined by download size using `partition_point`, which caused existing bars to shift around as new downloads started. Now new bars are always appended at the bottom, keeping existing bars stable. Since distributions are pre-sorted by descending size before downloading, larger downloads naturally appear first. https://claude.ai/code/session_019jaa7kQPg1ZE4DveMHKhNg
Invert the sort order so larger downloads appear at the top of the progress display. Previously the sizes list was in ascending order, putting small downloads at the top and causing new small downloads to push existing bars down. With descending order, new small downloads are added at the bottom, keeping the larger (longer-running) bars stable at the top. https://claude.ai/code/session_019jaa7kQPg1ZE4DveMHKhNg
zanieb
changed the title
Member
Author
|
This is less important when the number of downloads or uploads is less than the concurrency limit, as there's no secondary insertion in that case and the item just moves up rather than being displaced. I think this is still a bit better. |
Member
Author
Screen.Recording.2026-04-16.at.11.33.31.AM.movScreen.Recording.2026-04-16.at.11.34.03.AM.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using ascending order, we use descending order for progress reports. Larger downloads and uploads take longer. By inserting smaller items above them, we cause constant churn in the progress reporting. By inserting smaller items at the bottom, the progress should jump around less.