Skip to content

Temporarily disable newcomer approval CI gate - #1359

Merged
joshuajbouw merged 10 commits into
mainfrom
copilot/disable-ci-whitelist
Jul 24, 2026
Merged

Temporarily disable newcomer approval CI gate#1359
joshuajbouw merged 10 commits into
mainfrom
copilot/disable-ci-whitelist

Conversation

Copilot AI commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Linked Issue

No linked issue. This CI-only maintenance was requested to unblock PR #1321.

Summary

Temporarily disables the newcomer approval contributor gate and exempts
workflow-only pull requests from the linked-issue requirement.

Changes

  • add an ENFORCE_NEWCOMER_APPROVAL repository-variable toggle, defaulting to
    disabled
  • preserve the existing newcomer-approved enforcement logic behind that
    toggle
  • exempt PRs whose changed files are all under .github/workflows/ from the
    linked-issue gate in both PR-template validation and the dedicated check
  • avoid running the full Rust CI matrix for changes to unrelated workflows

Verification

Checklist

  • Workflow-only traceability exception documented
  • CHANGELOG not required for CI-only changes

Copilot AI requested a review from joshuajbouw July 24, 2026 13:30
@joshuajbouw
joshuajbouw marked this pull request as ready for review July 24, 2026 13:43
Copilot AI review requested due to automatic review settings July 24, 2026 13:43
@joshuajbouw joshuajbouw added the skip-changelog Skip changelog enforcement for this PR label Jul 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Temporarily disables the “new contributor requires newcomer-approved label” CI gate in the contributor-gate job, while keeping the enforcement logic in place behind an environment toggle so it can be re-enabled later.

Changes:

  • Introduces an ENFORCE_NEWCOMER_APPROVAL toggle for the contributor tier gate logic.
  • Wraps the newcomer-approved label enforcement in the toggle and emits a ::notice:: when enforcement is disabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pr-checks.yml Outdated
Comment thread .github/workflows/pr-checks.yml Outdated
Copilot AI requested a review from joshuajbouw July 24, 2026 15:13
@joshuajbouw
joshuajbouw merged commit f5b4b76 into main Jul 24, 2026
27 checks passed
@joshuajbouw
joshuajbouw deleted the copilot/disable-ci-whitelist branch July 24, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-only Don't run whole CI skip-changelog Skip changelog enforcement for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants