fix: remove vulnerable build dependencies - #28
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the workspace’s build-tool dependency graph to remove known vulnerable transitive paths ahead of the 0.2.0 release, and adds a dedicated CI job to enforce ongoing dependency auditing.
Changes:
- Upgraded
esbuildacross the workspace to^0.25.12. - Pinned
@bytecodealliance/componentize-jsto0.19.3and added/pinned compatible@bytecodealliance/jco1.17.8to keep downstream installs audit-clean. - Added a separate GitHub Actions “Dependency audit” job that runs
npm ciand fails on anynpm auditfindings at--audit-level=low.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/astrid-sdk/package.json | Bumps esbuild devDependency to the patched 0.25.x line. |
| packages/astrid-build/package.json | Pins componentize-js and adds pinned jco, plus upgrades esbuild, to remove vulnerable transitive dependencies for downstream consumers. |
| package-lock.json | Updates the lockfile to reflect the new pinned/updated dependency graph and removes the vulnerable weval → decompress chain. |
| CHANGELOG.md | Documents the security-related dependency/toolchain upgrades and the audit CI policy addition. |
| .github/workflows/ci.yml | Adds a dedicated “Dependency audit” job running npm ci + npm audit --audit-level=low. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the vulnerable build-tool dependency graph before publishing
0.2.0, and make dependency auditing a dedicated CI check.Security impact
@bytecodealliance/weval → decompress@4.2.1archive-extraction path (GHSA-mp2f-45pm-3cg9,GHSA-h39j-r5qq-r9mm)GHSA-67mh-4wv8-2f99)componentize-js@0.19.3and compatible@bytecodealliance/jco@1.17.8so downstream installs of@unicity-astrid/buildalso resolve the audit-clean graph0.25.xlineCI policy
Dependency auditjobnpm ciinstallnpm audit --audit-level=low, failing on any reported severitymainruleset as a required status checkValidation
npm cinpm audit --audit-level=low— 0 vulnerabilitiesa268eb3— 14.02 MB example, 178 host importsnpm test— 9/9 passed@unicity-astrid/build@0.2.0and@unicity-astrid/sdk@0.2.0git diff --checkRelease state
0.2.0has not been published to npm, and no remotev0.2.0tag or GitHub Release exists. After this merges, the firstv0.2.0tag can point directly at the correctedmain; no tag deletion or movement is needed.