feat: default input_stream to None to let SR.jl choose backend default#1208
Open
MilesCranmerBot wants to merge 2 commits into
Open
feat: default input_stream to None to let SR.jl choose backend default#1208MilesCranmerBot wants to merge 2 commits into
MilesCranmerBot wants to merge 2 commits into
Conversation
PySR previously passed input_stream="stdin" explicitly to SymbolicRegression.jl, overriding the backend default. This prevented SymbolicRegression.jl PR astroautomata#622 from autoselecting devnull on Windows/WSL where stdin hangs. With this change: - input_stream=None (default) omits the kwarg from Options(), letting SR.jl decide. - input_stream="stdin" or "devnull" still passes through explicitly. Fixes PySR issue astroautomata#832. References SymbolicRegression.jl PR astroautomata#622. Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1208 +/- ##
==========================================
- Coverage 94.24% 94.15% -0.10%
==========================================
Files 21 21
Lines 1686 1694 +8
==========================================
+ Hits 1589 1595 +6
- Misses 97 99 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MilesCranmerBot
force-pushed
the
input-stream-backend-default
branch
2 times, most recently
from
ce90a08 to
8105905
Compare
for more information, see https://pre-commit.ci
MilesCranmerBot
force-pushed
the
input-stream-backend-default
branch
from
8105905 to
4faea12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PySR previously passed
input_stream="stdin"explicitly to SymbolicRegression.jl, overriding the backend default. This prevented SymbolicRegression.jl PR #622 from autoselectingdevnullon Windows/WSL where stdin hangs.With this change:
input_stream=None(default) omits the kwarg fromOptions(), letting SR.jl decide.input_stream="stdin"or"devnull"still passes through explicitly.Fixes PySR issue #832.
References SymbolicRegression.jl PR #622 (
bot/autoselect-devnull-input-stream).Co-authored-by: Miles Cranmer miles.cranmer@gmail.com