fix: pin sklearn in conda CI#1253
Open
MilesCranmerBot wants to merge 1 commit into
Open
Conversation
MilesCranmerBot
referenced
this pull request
Jul 2, 2026
* chore(deps): consolidate GitHub Actions version bumps - julia-actions/setup-julia v2→v3 - docker/login-action v3→v4 - docker/metadata-action v5→v6 - docker/setup-qemu-action v3→v4 - docker/setup-buildx-action v3→v4 - docker/build-push-action v6→v7 Closes #1225 Closes #1170 * chore(deps): consolidate npm/docs dependency bumps - d3-format ^3.1.0 → ^3.1.2 - markdown-it ^14.1.0 → ^14.2.0 - markdown-it-mathjax3 ^4.3.2 → ^5.2.0 - vitepress-plugin-tabs ^0.6.0 → ^0.9.0 Closes #1227 Closes #1229 Closes #1231 Closes #1233
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
@MilesCranmerBot this feels like the wrong way to fix the issue... Please load ponytail skill and rewrite |
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
MilesCranmerBot
force-pushed
the
bot/sklearn-skiptest-ci
branch
from
9b6c697 to
708ef82
Compare
Contributor
Author
|
Rewritten in ponytail mode: dropped the sklearn pin and set That targets the actual scikit-learn 1.9 failure ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stabilizes the scheduled conda-forge workflow on Python 3.13 by keeping the released conda test environment on scikit-learn <1.9.
The failure was from scikit-learn 1.9's new array API estimator check raising
SkipTestwhenSCIPY_ARRAY_APIis unset. Current source already treatsunittest.SkipTestfrom sklearn checks as skipped; this pin is needed because the scheduled workflow tests the released conda package until the next PySR release.Verification:
git diff --checkunittest.SkipTestintest_scikit_learn_compatibilityactionlintis not installed locally