Remove the unused functions from ccdproc tutorials#290
Open
eteq wants to merge 2 commits intoastropy:mainfrom
Open
Remove the unused functions from ccdproc tutorials#290eteq wants to merge 2 commits intoastropy:mainfrom
eteq wants to merge 2 commits intoastropy:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
eteq
changed the title
Member
|
I wasn't involved in writing these notebook (I only fixed an astropy import issue 4+ years ago), but I completely agree with using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes that we change the ccdproc tutorials in two related ways:
astropy.visualizationinstead of a custom notebook-specificshow_imageconvenience_functions.pyfrom the ccdproc notebooks (since they are only used for show_image, anyway)My thinking here is that this now actually showcases astropy.visualization so people learn that it exists over the course of these tutorials, and makes the notebooks entirely standalone, which in general is good practice IMHO.
cc @mwcraig who I think originally wrote this and might have a dissenting option (although git says it was 5 years ago so it pre-dates the astropy.visualization functionality...), or perhaps @larrybradley who more recently modified these notebooks.