Harden OpenRouter completion handling - #283
Merged
Merged
Conversation
astrovm
marked this pull request as ready for review
July 28, 2026 04:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
finish_reason=Noneresponses and transient in-band OpenRouter errors with bounded exponential backoff.Why
OpenRouter occasionally returned an empty completion with
finish_reason=Noneduring web-search/tool flows. The bot treated it as terminal, emitted an admin alert, and fell back without retrying. Separately, DeepSeek reasoning could consume the previous 1,024-token output budget before producing a useful visible answer.Impact
Transient empty provider responses now recover automatically without retrying permanent or billable failures. DeepSeek gets enough room for reasoning, other models retain the existing output ceiling, retry accounting is accurate, and VPS admin reports are consistently in English.
Validation
uv run --locked ruff check api/ tests/uv run --locked python -m pytest -q— 866 passed