Retry Telegram message deletion - #284
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deleteMessageresponsesRoot cause
The deletion request suppressed errors, skipped JSON response validation, and had no retry handling. The bot therefore posted the repaired link even when a transient Telegram failure left the original message in place.
Impact
Repaired links are now posted first, while intermittent Telegram deletion failures receive bounded retries instead of being silently ignored.
Validation
uv run pytest -q tests/test_links.py tests/test_message_ai_media.py tests/test_telegram_gateway.py(64 passed)uv run ruff check api/bot/telegram.py api/bot/message_links.py tests/test_telegram_gateway.py tests/test_message_ai_media.pyuv run mypy api/bot/telegram.py api/bot/message_links.pygit diff --check