Skip to content

feat: add max-queued-records-per-shard metric (cherry-pick Confluent #905) #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
astubbs wants to merge 1 commit into
base: cherry-pick/893-offset-reset
Choose a base branch
from
+6 −1
Open

feat: add max-queued-records-per-shard metric (cherry-pick Confluent #905) #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/metrics/PCMetricsDef.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public enum PCMetricsDef {

INCOMPLETE_OFFSETS_TOTAL("incomplete.offsets.total", "Total number of incomplete offsets", PCMetricsSubsystem.SHARD_MANAGER, GAUGE),
SHARDS_SIZE("shards.size", "Number of records queued for processing across all shards", PCMetricsSubsystem.SHARD_MANAGER, GAUGE),
SHARDS_MAX_SIZE("shards.max.size", "The number of queued records in the shards with the most queued records", PCMetricsSubsystem.SHARD_MANAGER, GAUGE),


//TODO: Not implemented yet - add to Metrics.adoc when implemented
Expand Down
6 changes: 5 additions & 1 deletion parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/state/ShardManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public class ShardManager<K, V> {
private Optional<ShardKey> iterationResumePoint = Optional.empty();

private Gauge shardsSizeGauge;
private Gauge shardsMaxSizeGauge;
private Gauge numberOfShardsGauge;

private final PCMetrics pcMetrics;
Expand Down Expand Up @@ -302,7 +303,10 @@ private void initMetrics() {
shardsSizeGauge = pcMetrics.gaugeFromMetricDef(PCMetricsDef.SHARDS_SIZE,
this, shardManager -> shardManager.processingShards.values().stream()
.mapToInt(processingShard -> processingShard.getEntries().size()).sum());
shardsMaxSizeGauge = pcMetrics.gaugeFromMetricDef(PCMetricsDef.SHARDS_MAX_SIZE,
this, shardManager -> shardManager.processingShards.values().stream()
.mapToInt(processingShard -> processingShard.getEntries().size()).max().orElse(0));
numberOfShardsGauge = pcMetrics.gaugeFromMetricDef(PCMetricsDef.NUMBER_OF_SHARDS,
this, shardManager -> shardManager.processingShards.keySet().size());
this, shardManager -> shardManager.processingShards.size());
}
}
Loading