refactor(library): modularize Schema component and extract sub-components#1244
Closed
techmannih wants to merge 1 commit intoasyncapi:masterfrom
Closed
refactor(library): modularize Schema component and extract sub-components#1244techmannih wants to merge 1 commit intoasyncapi:masterfrom
techmannih wants to merge 1 commit intoasyncapi:masterfrom
Conversation
|
Author
|
hey @AceTheCreator Can I get your review. |
Member
|
Sorry, closing this PR. A PR doing exactly this already exists :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Changes proposed in this pull request:
library/src/components/Schema/directory to house the complex schema rendering logic.SchemaProperties,AdditionalProperties,SchemaItems, andAdditionalItemsinto separate, focused files to improve code readability and reduce cognitive complexity in the main component.SchemaContextto a dedicatedSchemaContext.tsxfile for better state isolation and cleaner component files.index.tswithin theSchemadirectory and updated the components' main entry point to maintain backward compatibility for existing imports.Schema.test.tsx(Circular references, boolean defaults, and array rendering) ensuring no regressions were introduced.Related issue(s)
Testing Results