Skip to content

Simplify e2e#30

Open
erseco wants to merge 2 commits intomainfrom
feature/simplify-e2e-tests
Open

Simplify e2e#30
erseco wants to merge 2 commits intomainfrom
feature/simplify-e2e-tests

Conversation

@erseco
Copy link

@erseco erseco commented Feb 18, 2026

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3631a31f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

await navText.click({ force: true });

// Wait briefly for page content to load
await page.waitForTimeout(200);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Wait for page content change after nav click

Using a fixed waitForTimeout(200) after switching pages makes this regression test timing-dependent: on slower CI or busy browsers, iDevices may still be rendering when counts are read, so renderedTypes/pagesWithIdevices are undercounted and the test becomes flaky. This should wait on a deterministic page-content signal (e.g., selected nav id reflected in content or iDevice container update) instead of a hardcoded sleep.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant