Add IconicFontButton and supporting code.#10
Open
niedzielski wants to merge 1 commit intoatermenji:masterfrom
Open
Add IconicFontButton and supporting code.#10niedzielski wants to merge 1 commit intoatermenji:masterfrom
niedzielski wants to merge 1 commit intoatermenji:masterfrom
Conversation
Author
|
Rebased. I realize this commit is a starting point but I think it's a valuable direction for the library to go. Let me know what you think or changes are needed to get this in. Thanks. |
Owner
|
@niedzielski thanks a lot, I'll take a look at your commits soon, when I'll manage to find some free time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new class, IconicFontButton. It's an Android button with built in support for an IconicDroid background, customizable via plain XML. It's a little rough around the edges, but worked for my purposes. That said, I'm happy to make changes. If we merge this, we should consider updating the demo to show the new functionality simply by adding the following to a layout file: