feat: support Temporal Server 1.30.x#17
Merged
Merged
Conversation
Temporal Server 1.30 slimmed the temporalio/server image: dockerize was removed
and config templating moved into the server binary (embedded sprig, opt-in via a
leading '# enable-template' comment and located via TEMPORAL_SERVER_CONFIG_FILE_PATH).
The operator mounts an unrendered config_template.yaml and sets no start command,
so on a stock 1.30 image the dockerize-style {{ .Env.X }} placeholders never
resolve and server pods crash-loop.
Changes:
- version: widen SupportedVersionsRange to < 1.31.0; add 30 -> 1.30.6 to
RecommendedVersions; add V1_30_0; mark 1.30.0 broken (no published release).
- config: for clusters >= 1.30, emit sprig placeholders ({{ env "X" }},
{{ default "0.0.0.0" (env "POD_IP") }}) and prepend '# enable-template';
pre-1.30 dockerize behavior unchanged.
- deployment: for >= 1.30, set TEMPORAL_SERVICES and TEMPORAL_SERVER_CONFIG_FILE_PATH
on the server container.
Mirrors upstream alexandrevilain#987, scoped to 1.30.x
(no 1.31 PasswordCommand / Elasticsearch-tool changes).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tczhao
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: support Temporal Server 1.30.x
Problem
Temporal Server 1.30 slimmed the
temporalio/serverimage:dockerizewas removed and config templating moved into the server binary (embeddedsprig, opt-in via a leading# enable-templatecomment, and the config file located viaTEMPORAL_SERVER_CONFIG_FILE_PATH). The operator mounts an unrenderedconfig_template.yamland sets no start command, so on a stock 1.30 image the dockerize-style{{ .Env.X }}placeholders never resolve and every server pod crash-loops. The version webhook also caps supported versions below 1.30.Changes
pkg/version/version.go,upgrade.go): widenSupportedVersionsRangeto< 1.31.0; add30 -> 1.30.6toRecommendedVersions; add theV1_30_0boundary constant; mark1.30.0broken (it has no published GitHub release — use1.30.1+).internal/resource/config/configmap_builder.go): for clusters>= 1.30, emitsprigplaceholders ({{ env "X" }},{{ default "0.0.0.0" (env "POD_IP") }}) and prepend the# enable-templatemarker. Pre-1.30 dockerize.Envbehavior is unchanged (version-gated).internal/resource/base/deployment_builder.go): for>= 1.30, setTEMPORAL_SERVICES(service selection) andTEMPORAL_SERVER_CONFIG_FILE_PATHon the server container.Scoped to what 1.30.x needs. This mirrors the config-rendering approach in upstream PR alexandrevilain#987, but deliberately omits its 1.31-only pieces (the
PasswordCommanddatastore field and the Elasticsearch-tool schema changes), since this fork targets 1.30.6 with Postgres visibility.Testing
go build/go vetclean onpkg/version,internal/resource/config,internal/resource/base.configmap_builder_internal_test.go) asserting dockerize syntax pre-1.30 and sprig syntax>= 1.30.sprigtemplate renders with nil template data (the way the server invokes it) — env vars resolve andPOD_IPfalls back to0.0.0.0, no placeholders left.Note on base branch
Targets
main-0.22-atlan-0.1(the fork's active line — the branchbuild.yamlpublishes the operator image from), consistent with the other operator PRs on this line.🤖 Generated with Claude Code