Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions spec/composite-disposable-spec.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,13 @@ describe "CompositeDisposable", ->
expect(disposable1.disposed).toBe true
expect(disposable2.disposed).toBe false
expect(disposable3.disposed).toBe true

describe "::addIfDisposable(disposables...)", ->
it "ignores disposables without a ::dispose function", ->
composite = new CompositeDisposable
composite.addIfDisposable(disposable1, undefined, null)
composite.addIfDisposable(whatever: ->)

composite.dispose()

expect(disposable1.disposed).toBe true
12 changes: 12 additions & 0 deletions src/composite-disposable.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,18 @@ class CompositeDisposable
@disposables.add(disposable) for disposable in arguments
return

# Public: Add a disposable to be disposed when the composite is disposed,
# ignoring it if it does not implement `.dispose()`.
#
# See {CompositeDisposable::add} documentation for further information.
#
# * `disposable` {Disposable} instance or any object with a `.dispose()`
# method.
addIfDisposable: ->
for disposable in arguments
@add(disposable) if typeof disposable?.dispose is "function"
return

# Public: Remove a previously added disposable.
#
# * `disposable` {Disposable} instance or any object with a `.dispose()`
Expand Down