Decaffeinate lib/project/results-model#948
Conversation
It's especially useful and appreciated to have this change as its own PR. 💟 Would you mind converting the code to standard style. I recommend running: In addition to adjusting the code in place, the output may include some additional suggested edits. If so, can you please address those as well? Once that's done, please let us know and we can review this PR and work toward getting it merged. |
the only command line output that I left is "atom undefined"
|
@jasonrudolph - thanks for the suggestion - done with that. |
jasonrudolph
left a comment
There was a problem hiding this comment.
@bmperrea: Thanks for the updates. ⚡
I pushed up a few tweaks (b076686...478d93d). Once the build finishes running, I'll merge this PR.
|
👍 |
Description of the Change
Change
lib/project/results-model.coffeetolib/project/results-model.jsusing decaffeinate and some human linting.Alternate Designs
We could leave it as .coffee, but this comment suggests things are moving to ES6, and I would work on this file if it was in Javascript.
I could save this translation as part of a feature PR, but I thought it was useful to make translation a PR of it's own so that the changes on top of that will be easy to track.
Benefits
People don't have to figure out coffeescript to contribute.
Possible Drawbacks
You can't use coffeescript for this file anymore
Applicable Issues
I might add function-replace for project as in issue #417 if I can use es6 Javascript.