This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Keybinding Resolver conflict with Emmet#239
Open
kmilov wants to merge 1 commit intoatom:masterfrom
kmilov:bug/keymaps-commas
Open
Keybinding Resolver conflict with Emmet#239kmilov wants to merge 1 commit intoatom:masterfrom kmilov:bug/keymaps-commas
kmilov wants to merge 1 commit intoatom:masterfrom
kmilov:bug/keymaps-commas
Conversation
…hange it to editor not mini
Contributor
There was a problem hiding this comment.
This should use the data attributes instead and keep targeting the element instead of the class.
atom-workspace atom-text-editor:not([mini])
See https://github.com/atom/atom/blob/74a627d41b41ce39e0a5ad43a08dbd4ce2a46fcc/keymaps/darwin.cson#L139 for an example
|
@kmilov @kevinsawicki Mind if I take this on? This is still an issue for me when I have both the emmet and markdown-preview packages installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a conflict with the ctrl+M key map when the user have the Emmet package installed.
This change will prevent the error. also, the Keybinding resolver doesn't support the comma operator.