Skip to content

TypeSchema: Remove NestedIdentifier from Identifier union - #116

Closed
ryukzak wants to merge 1 commit into
rename-type-identifier-and-nested-type-schemafrom
remove-nested-from-identifier
Closed

TypeSchema: Remove NestedIdentifier from Identifier union#116
ryukzak wants to merge 1 commit into
rename-type-identifier-and-nested-type-schemafrom
remove-nested-from-identifier

Conversation

@ryukzak

@ryukzak ryukzak commented Mar 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Remove NestedIdentifier from Identifier union — Identifier now contains only 7 non-nested kinds
  • TypeIdentifier = Identifier | NestedIdentifier (introduced in base branch) becomes the wider alias
  • Export LogicalIdentifier
  • extractDependencies now filters out all nested identifiers from dependency lists
  • Split transformFhirSchema into separate profile/specialization branches for correct typing
  • Add nestedIndex fallback in resolveByUrl so constrainedChoice resolves nested types
  • Remove dead isNestedIdentifier/kind === "nested" branches in TS writer
  • Add as SpecializationTypeSchema casts in Python, C#, and tree-shake for NestedTypeSchemaTypeSchema boundaries

Before (dependencies included nested identifiers):

dependencies: [
    { kind: "resource", name: "a", url: "uri::A" },
    { kind: "nested", name: "foo", url: "uri::A#foo" },
]

After (nested identifiers filtered out):

dependencies: [{ kind: "resource", name: "a", url: "uri::A" }]

- Identifier is now the union of 7 non-nested kinds (primitive, complex-type,
  resource, binding, value-set, profile, logical)
- TypeIdentifier = Identifier | NestedIdentifier serves as the wider alias
- Export LogicalIdentifier
- extractDependencies filters out all nested identifiers
- Split transformFhirSchema into profile/specialization branches
- Add nestedIndex fallback in resolveByUrl for constrainedChoice
- Remove dead nested-handling branches in TS writer
- Add casts in Python, C#, tree-shake for NestedTypeSchema ↔ TypeSchema
@ryukzak ryukzak closed this Mar 23, 2026
@ryukzak
ryukzak deleted the remove-nested-from-identifier branch March 23, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant