TypeSchema: Remove NestedIdentifier from Identifier union - #116
Closed
ryukzak wants to merge 1 commit into
Closed
Conversation
- Identifier is now the union of 7 non-nested kinds (primitive, complex-type, resource, binding, value-set, profile, logical) - TypeIdentifier = Identifier | NestedIdentifier serves as the wider alias - Export LogicalIdentifier - extractDependencies filters out all nested identifiers - Split transformFhirSchema into profile/specialization branches - Add nestedIndex fallback in resolveByUrl for constrainedChoice - Remove dead nested-handling branches in TS writer - Add casts in Python, C#, tree-shake for NestedTypeSchema ↔ TypeSchema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NestedIdentifierfromIdentifierunion —Identifiernow contains only 7 non-nested kindsTypeIdentifier = Identifier | NestedIdentifier(introduced in base branch) becomes the wider aliasLogicalIdentifierextractDependenciesnow filters out all nested identifiers from dependency liststransformFhirSchemainto separate profile/specialization branches for correct typingnestedIndexfallback inresolveByUrlsoconstrainedChoiceresolves nested typesisNestedIdentifier/kind === "nested"branches in TS writeras SpecializationTypeSchemacasts in Python, C#, and tree-shake forNestedTypeSchema↔TypeSchemaboundariesBefore (
dependenciesincluded nested identifiers):After (nested identifiers filtered out):