This repository was archived by the owner on Apr 15, 2018. It is now read-only.
Replace CatalystThread with ScheduledExecutorService wrapper#55
Open
maguro wants to merge 1 commit intoatomix:masterfrom
Open
Replace CatalystThread with ScheduledExecutorService wrapper#55maguro wants to merge 1 commit intoatomix:masterfrom
maguro wants to merge 1 commit intoatomix:masterfrom
Conversation
A potentially "cleaner" implementation of ThreadContext. It centralizes the management of the ThreadContext without extensive collaboration and implementation leaks, e.g. checkThread(). A fair bit of code was removed in the process. This change is backwards incompatible, hence the major version bump.
maguro
changed the title
CatalystThread with ScheduledExecutorService wrapper
Member
|
I know it's been a while. I've been off working on other major projects, but am still very much working on progressing these projects. So, I think this could be hugely helpful. I'm actually in the process of writing version 2.0 of Copycat and Atomix and I think quite a bit of the code will change to support an HTTP/WebSocket API. So, this should probably become a part of that effort. I'm going to leave this open here and see how we can fit it in. |
Author
|
Hey, no worries. Re-reading this code, I was thinking that ideally there would be no need for thread locals at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A potentially "cleaner" implementation of
ThreadContext. It centralizesthe management of the
ThreadContextwithout extensive collaborationand implementation leaks, e.g.
checkThread(). A fair bit of code wasremoved in the process.
This change is backwards incompatible, hence the major version
bump.