Skip to content

Blow up tests on purpose to make sure github action fails #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atorch wants to merge 3 commits into from
Closed

Blow up tests on purpose to make sure github action fails #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6950400
Blow up tests on purpose to make sure github action fails
atorch Aug 26, 2025
b4a2613
Fix testCorrectAnswer to make sure the other steps fail
atorch Aug 26, 2025
b3f71b5
Update app/src/androidTest/java/atorch/statspuzzles/PuzzleSelectionTe…
atorch Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/actions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
locale: ['en-US', 'de-DE', 'es-ES', 'ar-EG']
locale: ['en-US', 'de-DE', 'es-ES', 'ar-EG', 'fr-FR']
Copy link
Copy Markdown
Owner Author

@atorch atorch Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, we don't have a fr-FR translation, shouldn't this blow up?

steps:
- name: checkout
uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions app/src/test/java/atorch/statspuzzles/AnswerCheckerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ public void testCorrectAnswer() {
// Note that we have a Result.INACCURATE version of this test as well
assertEquals(AnswerChecker.Result.CORRECT, AnswerChecker.checkAnswer("1/3", "0.33333333333333"));
assertEquals(AnswerChecker.Result.CORRECT, AnswerChecker.checkAnswer("C(5, 3)", "10"));
assertEquals(AnswerChecker.Result.CORRECT, AnswerChecker.checkAnswer("1/(3!)", "0.16666666"));
}

@Test
Expand Down