This repository was archived by the owner on Aug 5, 2025. It is now read-only.
feat: Websocket uptake in at_lookup#732
Open
purnimavenkatasubbu wants to merge 6 commits intotrunkfrom
Open
Conversation
gkc
suggested changes
Dec 11, 2024
Contributor
There was a problem hiding this comment.
Functional tests are failing https://github.com/atsign-foundation/at_libraries/actions/runs/12242458255/job/34149828665?pr=732
Contributor
Author
Yes Gary, Websocket tests will pass only with the websocket server branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Implemented WebSocket support by introducing a new connection factory structure to support both SecureSocket and WebSocket connections. This update allows AtLookupImpl to dynamically choose between secure socket and WebSocket connections, enhancing flexibility and enabling WebSocket-based communication when required.
- How I did it
- How to verify it
- Description for the changelog
add WebSocket support in AtLookupImpl