-
-
Notifications
You must be signed in to change notification settings - Fork 1
Support for using font not system installed #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a95c713
feat: support font-paths from arguments and environment variavles
attakei b4e7201
docs: add description about added option
attakei 33197c9
docs: fix text for CodeRabbit
attakei 74d93dd
fix: ignore empty TYPST_FONT_PATHS environment variable
attakei aebc162
fix: parse --font-paths as a list instead of a raw string
attakei c24f766
fix: normalize font_paths to a list regardless of input source
attakei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import os | ||
| from unittest.mock import patch, MagicMock | ||
|
|
||
| import pytest | ||
| from docutils.core import publish_string | ||
|
|
||
| from rst2typst import pdf | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def _clear_font_paths_env(monkeypatch: pytest.MonkeyPatch): | ||
| monkeypatch.delenv("TYPST_FONT_PATHS", raising=False) | ||
|
|
||
|
|
||
| def _publish(**settings_overrides) -> MagicMock: | ||
| with patch.object(pdf.typst, "compile") as mock: | ||
| publish_string( | ||
| "", | ||
| writer=pdf.Writer(), | ||
| settings_overrides=settings_overrides, | ||
| ) | ||
| return mock | ||
|
|
||
|
|
||
| def test_font_paths_is_not_set(): | ||
| mock = _publish() | ||
| assert mock.call_args.kwargs["font_paths"] == [] | ||
|
|
||
|
|
||
| def test_font_paths_from_args(): | ||
| mock = _publish(font_paths=["/tmp/fonts"]) | ||
| assert mock.call_args.kwargs["font_paths"] == ["/tmp/fonts"] | ||
|
|
||
|
|
||
| def test_font_paths_from_args_str(): | ||
| mock = _publish(font_paths="/tmp/fonts") | ||
| assert mock.call_args.kwargs["font_paths"] == ["/tmp/fonts"] | ||
|
|
||
|
|
||
| def test_font_paths_from_env(monkeypatch: pytest.MonkeyPatch): | ||
| monkeypatch.setenv( | ||
| "TYPST_FONT_PATHS", os.pathsep.join(["/opt/fonts", "/tmp/fonts"]) | ||
| ) | ||
| mock = _publish() | ||
| assert mock.call_args.kwargs["font_paths"] == [ | ||
| "/opt/fonts", | ||
| "/tmp/fonts", | ||
| ] | ||
|
|
||
|
|
||
| def test_font_paths_from_args_and_env(monkeypatch: pytest.MonkeyPatch): | ||
| monkeypatch.setenv("TYPST_FONT_PATHS", "/opt/fonts") | ||
| mock = _publish(font_paths=["/tmp/fonts"]) | ||
| assert mock.call_args.kwargs["font_paths"] == [ | ||
| "/tmp/fonts", | ||
| "/opt/fonts", | ||
| ] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.