Open
Conversation
There was a problem hiding this comment.
You are calling the same code in both if branches. You can just put it above if statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description: While access_token is refreshing the method RubyBox::Session.request is called twice with the same request param. That cause twice call of
request.add_field('Authorization', "Bearer #{@access_token.token}")
That lead to wrong header like authorization: Bearer oldaccess_token, Bearer newaccess_token
and failed auth
This fix assures there is no extra header (and also the same for the header As-User)