Skip to content

Rename --model → --lm and --text-encoder → --embedding in ace-* CLI invocations #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmangani merged 2 commits into from
Mar 18, 2026
Merged

Rename --model → --lm and --text-encoder → --embedding in ace-* CLI invocations #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84689b2
Initial plan
Copilot Mar 18, 2026
c6ab1dc
rename --model→--lm and --text-encoder→--embedding in ace-* invocations
Copilot Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/routes/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ router.post('/format', authMiddleware, async (req: AuthenticatedRequest, res: Re
if (timeSignature) reqJson.timesignature = timeSignature;
await wf(reqPath, JSON.stringify(reqJson, null, 2));

const args: string[] = ['--request', reqPath, '--model', config.acestep.lmModel];
const args: string[] = ['--request', reqPath, '--lm', config.acestep.lmModel];
const { spawn } = await import('child_process');
const result = await new Promise<{ stdout: string; stderr: string; code: number }>((resolve) => {
const proc = spawn(config.acestep.lmBin!, args, { shell: false, stdio: ['ignore', 'pipe', 'pipe'] });
Expand Down
6 changes: 3 additions & 3 deletions server/src/services/acestep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ async function runViaSpawn(
const lmModel = config.acestep.lmModel;
if (!lmModel) throw new Error('LM model not found — run models.sh first');

const lmArgs: string[] = ['--request', requestPath, '--model', lmModel];
const lmArgs: string[] = ['--request', requestPath, '--lm', lmModel];

const batchSize = Math.min(Math.max(params.batchSize ?? 1, 1), 8);
if (batchSize > 1) lmArgs.push('--batch', String(batchSize));
Expand Down Expand Up @@ -717,7 +717,7 @@ async function runViaSpawn(

const ditArgs: string[] = [
'--request', ...enrichedPaths,
'--text-encoder', textEncoderModel,
'--embedding', textEncoderModel,
'--dit', ditModel,
'--vae', vaeModel,
];
Expand Down Expand Up @@ -1209,7 +1209,7 @@ export async function runUnderstand(audioUrl: string): Promise<UnderstandResult>
'--src-audio', srcAudioPath,
'--dit', ditModel,
'--vae', vaeModel,
'--model', lmModel,
'--lm', lmModel,
'-o', outJsonPath,
];

Expand Down
Loading