feat(svg): add single-outline symbol for CAD import#40
Merged
Conversation
Signed-off-by: Aaron Cupp <mrcupp@mrcupp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32. Part of #26 (Phase 3 — extension).
The canonical
audiophore-symbol.svgis 13 separate<rect>s, each with its own spectrum color and a partial opacity for the depth ramp. Both are meaningless in CAD — and worse, OpenSCAD'simport()treats the multi-color, multi-element art as something it can't cleanly extrude. So the hardware repo hand-rebuilds the 13-pixel phi as adiamond_pixelscell list in SCAD, a parallel copy that drifts from the brand spec.This emits a flattened companion —
logos/svg/audiophore-symbol-solid.svg— where the lit cells are one<path>(one rounded-rect subpath per cell), a single flat fill, no opacity, same 320-unit viewBox as the canonical mark.import()+linear_extrudegives one clean solid; hardware imports the canonical geometry instead of maintaining its own.New
[cad]section inbrand.toml(just the flat fill key); folded into thesymbolbuild step somake svgs/buildproduces it. Same grid math as the canonical symbol, so the silhouette is identical. Byte-identical on rebuild.