feat(icons): generate Tauri desktop icon set from brand.toml#42
Merged
Conversation
Signed-off-by: Aaron Cupp <mrcupp@mrcupp.com>
Member
Author
|
Switched |
978cc16 to
464edcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30. Part of #26 (Phase 3 — extension).
The Tauri prototype in
audiophore/audiophoreships flat-color placeholder icons — committed once, never the real mark. This generates the actual set itstauri.conf.jsoniconarray expects:logos/icons/icon.icns— full macOS set (16/32/128/256/512 + @2x), written by a small pure-Python ICNS writer. No macOSiconutilin the build path (it's absent on the ubuntu CI runner); verified thaticonutilitself parses the output.logos/icons/icon.ico— multi-res Windows/app icon (16–256), via ImageMagick, the same pathfavicon.icoalready uses.logos/icons/{32x32,128x128,128x128@2x}.png— the PNGs the icon array points at directly.New
[icons.desktop]section inbrand.toml(source variant +.icosizes). The.icnsis byte-identical on rebuild; the webfavicon.icowas never a substitute for a desktop app icon.Wiring these into
tauri.conf.jsonis a follow-up in the app repo.